Skip to content

add bytes type decode process #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2019
Merged

add bytes type decode process #44

merged 1 commit into from
Dec 23, 2019

Conversation

timesong
Copy link
Contributor

@timesong timesong commented Sep 7, 2019

for unicode char output.

konichuvak
konichuvak reviewed Nov 19, 2019
View reviewed changes
Copy link

@konichuvak konichuvak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super useful when dealing with strings, thank you!

@swilly22
Copy link
Contributor

@timesong, Thank you for this PR, would you mind adding test covering this feature?

@mingen-pan
Copy link
Contributor

It seems that right now the string passed to parse_scalar is always str not bytes.

@swilly22 swilly22 merged commit 3e84f57 into RedisGraph:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konichuvak konichuvak konichuvak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timesong @swilly22 @mingen-pan @konichuvak